v0.7 Release – Reducing Code Duplication

Posted on March 14, 2009 by Sid

I’ve decided to make a small change for this release along with the other changes that I have already outlined. I want to avoid code duplication as much as possible and thus I have decided to put code to create a rev link into a function. Currently the code for creating a rev link looks like the following:

var tdScrollChangeset = document.createElement("td");
tdScrollChangeset.innerHTML += 
  '<a href="/rev/' + 
  pushData[i].individualChangeset.substring(0, 12) + 
  '">' + 
  pushData[i].individualChangeset.substring(0, 12) + 
  '</a>';

After my change the code looks like the following:

var tdScrollChangeset = createRevLink(pushData[i].individualChangeset);

function createRevLink(str) {
  var td = document.createElement("td");
 
  td.innerHTML +=
    '<a href="/rev/' +
    str.substring(0, 12) + 
    '">' + 
    str.substring(0, 12) +
    '</a>'; 
 
  return td;
}

This alteration reduces the number of lines of code but keeps the same functionality. A win win by all accounts.

This entry was posted in DPS911, Mercurial Project, Open Source and tagged JavaScript, OnScroll, reduce code. Bookmark the permalink.

2 Responses to v0.7 Release – Reducing Code Duplication

Justin Wood (Callek) says:

March 15, 2009 at 5:22 pm

I didn’t note this on bug, but as a NIT: perhaps a rename of createRevLink to createRevTd(rev) would make sense.

Letting the attrib indicate what to pass in, and the function name indicating what it returns, which is _not_ an anchor element like I thought when skimming your code.

Reply
Justin Wood (Callek) says:

March 15, 2009 at 5:22 pm

s/attrib/argument/ from my last comment.

Reply

Leave a Reply Cancel reply