Posts Tagged bug
v0.7 Release Goals
Posted by Sid in DPS911, Mercurial Project, Open Source on March 12th, 2009
It’s time for another release for hgweb. I had thought about working on a new feature this release by I’ve decided to push that back to the next release. This time around I completely want to focus on one bug, getting pushloghtml to show more than 10 entries at a time.
Why? Well, I’ve put out multiple patches for this bug and it’s still not perfect. I realize that in software development bugs will always pop up somewhere but I’m just not satisfied with where my solution for this bug is right now. I really want to push for a complete solution this time around. The following are my goals for this release:
- The function which retrieves the total amount of entries in the database, getMaxEntries() is causing the browser to freeze. Find a solution for this problem
- Initially only 10 entries are displayed which means that the scroll bar doesn’t show up and thus more entries can’t be loaded since the OnScroll event doesn’t get called. Solve this problem by dynamically loading enough entries, according to the users screen size, until the scroll bar appears. I’ve tried various solutions for this problem, none of which have worked well so far. I want to solve this once and for all
- I’ve discovered a weird bug (I seem to have a weird talent of discovering obscure bugs) when displaying merge changesets. Some of them are not being displayed at all. Find a solution for this bug
- I’ve noticed another possible bug with merge changesets where, sometimes the last entry in a merge changeset is repeated in the next entry. Now, is this is a bug or not? Note sure. I need to investigate
v0.3 Release - Problem with my Patch for bug 445560
Posted by Sid in Mercurial Project, Open Source on November 24th, 2008
I had a discussion with ted today relating to my patch for bug 445560 for the pushlog. There seems to be a slight problem with it. When there are 2 merges on one page, if one clicks the second expand link, it shows those changesets, but the row with the [Expand] link disappears (example of the problem). This is a problem that we don’t want happening.
Problem
Currently I’m using the date as a unique identifier (view here for full details) but if somehow (very unlikely, but possible) two rows have the same date then there will be a problem, which is the case with the example linked above.
Fix
This problem can be solved by using the id as the unique identifier instead of the date. This will work because each changeset has a different id and each set merge changesets have the same id so it will allow one to identify all the merge changesets to hide on a page and not hide the ones that shouldn’t be hidden.
I will be putting up a new patch to fix this issue.
Edit: I didn’t read the comments (comment #6) that ted put on bug 445560 for my patch before I made this post. There is another problem that he identified, which I need to fix. Apparently I’m not allowed to have multiple elements with the same id so I can’t be putting my unique identifiers in the id of the tag. ted recommended putting them in the class of the tag which is what I will be doing. Look out for a new blog post explaining the code.