The point is that var is scoped to the whole function, and as such that once you define it, the entire function (not just that block) can use it.

Alternatively use |let| at the highest scope you need to (in this case, probably the for loop)

Until recently I was putting the curly braces on a new line whenever I was writing new code. However, I’ve noticed that not many projects follow this style. They prefer to put the curly braces on the same line. I’ve always found it easier to read the code if the braces are on a new line so I don’t understand why most people prefer to the other convention (braces on the same line).

As for line breaks, I’m with you. I don’t like to bunch everything up together. I prefer gaps, which increases readability, at least for me.

As for spaces, I prefer no space between function names and opening parentheses, but spaces between parentheses and arguments. The same goes for other parentheses—spaces on the inside side of them. As for line breaks, I’m a lot freer with them than the Bespin code seems to be. I like to separate things logically so it’s not all bunched together.

(And, yes, I’m aware you’re not talking about Bespin. It’s just the only difference in coding styles that I can relate to recently.)

If people need to see what the merge’s parents are they can click through to see the merge.

So it sounds like what happens here is that you are displaying the merge’s parent(s) rather than the the push’s themselves.

Realize that a merge will always have two parents, one of which is *very likely* to have been there from a previous push.

In future I may have time to stare at this code with you and work out a solution if you don’t beat me to it.