Comments on: v0.7 Release – Reducing Code Duplication http://blog.sidkalra.com/2009/03/v07-release-reducing-code-duplication/ Sun, 03 Jul 2011 03:10:04 +0000 hourly 1 http://wordpress.org/?v=3.2.1 By: Justin Wood (Callek) http://blog.sidkalra.com/2009/03/v07-release-reducing-code-duplication/#comment-90 Justin Wood (Callek) Mon, 16 Mar 2009 00:22:52 +0000 http://blog.sidkalra.com/?p=413#comment-90 s/attrib/argument/ from my last comment. s/attrib/argument/ from my last comment.

]]> By: Justin Wood (Callek) http://blog.sidkalra.com/2009/03/v07-release-reducing-code-duplication/#comment-89 Justin Wood (Callek) Mon, 16 Mar 2009 00:22:35 +0000 http://blog.sidkalra.com/?p=413#comment-89 I didn't note this on bug, but as a NIT: perhaps a rename of createRevLink to createRevTd(rev) would make sense. Letting the attrib indicate what to pass in, and the function name indicating what it returns, which is _not_ an anchor element like I thought when skimming your code. I didn’t note this on bug, but as a NIT: perhaps a rename of createRevLink to createRevTd(rev) would make sense.

Letting the attrib indicate what to pass in, and the function name indicating what it returns, which is _not_ an anchor element like I thought when skimming your code.

]]>